Make sure unzipped directories are owner-executable #387
Conversation
kiendang
force-pushed
the
unzip-dir-executable
branch
from
05fd1f1 to
f82fafc
Compare
|
Thanks @kiendang ! Seems like we may need to skip this on Windows which doesn't support POSIX permissions |
|
I think we should add |
|
@kiendang as long as we can unzip the problematic |
|
Hmm then I think the correct fix should be unzipping everything successfully, with the exact permissions specified. Then users fix the permissions at the call site? For the android case it would be val unzipped = os.unzip(...)
makeSureDirsHaveExecuteAndReadPerms(unzipped)Because we don't have control over the jars. If later some jar has Would be a simple fix as well. Will submit a separate PR. |
to prevent crash in cases where directories is missing READ/EXECUTE permission Added a test that - creates a zip file with directories without READ/EXECUTE permissions - `os.unzip` everything successfully - re-adds READ and EXECUTE permissions to directories see my and @lefou's comments #387 (comment) com-lihaoyi/mill#5048 (comment) Tested with the android test. Here is the permission fix at the call site (`AndroidApModule.scala`) com-lihaoyi/mill@main...kiendang:mill:fix-android-classesjar-unzip#diff-49ebd9c68d1348785194e15a80d62f0845c26386e722d3f5d43429238bbf7616 @lihaoyi @vaslabs
3 participants
No description provided.